Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] fpath-base (2 packages) (0.2.1) #26603

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

mbarbin
Copy link
Contributor

@mbarbin mbarbin commented Sep 23, 2024

This is the initial release for 2 packages fpath-sexplib0 and fpath-base. Short synopsis below, more information at https://github.com/mbarbin/fpath-base

fpath-sexplib0

This package only depends on fpath and sexplib0. It defines a single module, Fpath_sexplib0, which is designed to be opened to shadow the Fpath module to add small helpers and a sexp serializer to it. The package also introduces three new modules to the scope: Fpart, Absolute_path and Relative_path to increase type-safety when manipulating paths that are known to be relative or absolute.

fpath-base

This package further extends fpath-sexplib0 and adds a dependency on base. It is designed to be compatible with Base-style containers such as Map, Set, Hashtbl, Hash_set.

Motivation

This is a dependency to my vcs project. Publishing these packages to opam brings me one step closer to publishing vcs to opam one day. Thanks for your consideration!

@avsm
Copy link
Member

avsm commented Sep 25, 2024

Is this still a draft or it is ready for merging?

@mbarbin
Copy link
Contributor Author

mbarbin commented Sep 25, 2024

Is this still a draft or it is ready for merging?

Still draft - It's missing a maintenance email at the moment. I'll update the PR with one soon. Thank you!

Edit: Now ready for review

  • added a maintenance email

@mbarbin mbarbin marked this pull request as ready for review September 26, 2024 10:33
@shonfeder
Copy link
Contributor

Thanks, @mbarbin! I still owe you a response, which I've not forgotten.

Appreciate you taking the time to publish your work :)

Don't forget to announce on discuss, if you're inclined!

@shonfeder shonfeder merged commit a794ac5 into ocaml:master Sep 27, 2024
3 checks passed
@mbarbin mbarbin deleted the release-fpath-base branch September 27, 2024 16:30
@mbarbin
Copy link
Contributor Author

mbarbin commented Sep 27, 2024

Thank you @shonfeder for the review, and your encouraging comments, much appreciated!

Re:discuss - I'm inclined! I have a couple more packages in the pipeline now that loc is published, and plan on doing on joined announce with related packages (I'm thinking of https://github.com/mbarbin/file-rewriter next - I expect you'll see a PR about this sometimes next week). Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants